Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ci) mark flakey test suites as "continue-on-error: true" #2874

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

ramin
Copy link
Contributor

@ramin ramin commented Oct 26, 2023

in the interest of having a full pipeline for release 0.12.0, have marked the swamp and unit w/ race tests to continue-on-error: true so though the job will still fail in ci, the pipeline and dependent steps after those tests (namely version_bump + goreleaser) will still proceed as though they were successful, and we can get signed binaries with the tagged release

…n complete a release pipeline and get signed binaries with release
@ramin ramin added the kind:ci CI related PRs label Oct 26, 2023
@ramin ramin self-assigned this Oct 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Merging #2874 (d39a464) into main (f6a649e) will decrease coverage by 1.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2874      +/-   ##
==========================================
- Coverage   51.85%   50.32%   -1.53%     
==========================================
  Files         167      167              
  Lines       10801    10801              
==========================================
- Hits         5601     5436     -165     
- Misses       4708     4880     +172     
+ Partials      492      485       -7     

see 9 files with indirect coverage changes

@ramin ramin requested a review from MSevey October 26, 2023 13:14
@ramin
Copy link
Contributor Author

ramin commented Oct 26, 2023

@MSevey have a look at the changes i had to add to version_bump here, seems it hadn't run in a looooooooong time but was failing once i was skipping flakey tests, copied what we have in celestia-app

@MSevey
Copy link
Member

MSevey commented Oct 26, 2023

@MSevey have a look at the changes i had to add to version_bump here, seems it hadn't run in a looooooooong time but was failing once i was skipping flakey tests, copied what we have in celestia-app

@ramin there is currently a bug in app's version bumping that I'm digging into.
celestiaorg/celestia-app#2688

Will circle back once I've fixed app to know if there are changes to reapply here.

@MSevey
Copy link
Member

MSevey commented Oct 27, 2023

@ramin I would add this update to the version_bump job https://github.com/celestiaorg/celestia-app/pull/2773/files

This ensures proper handling of any non master/main release branches.

Copy link
Member

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs update to version bump.

@ramin
Copy link
Contributor Author

ramin commented Oct 30, 2023

@MSevey ok this is up to date

MSevey
MSevey previously approved these changes Oct 30, 2023
@ramin ramin enabled auto-merge (squash) October 30, 2023 16:38
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@ramin ramin merged commit 62e1769 into main Oct 30, 2023
19 checks passed
@ramin ramin deleted the ci/ramin/complete-pipeline branch October 30, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:ci CI related PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants