Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ci) mark flakey test suites as "continue-on-error: true" #2874

Merged
merged 5 commits into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .github/workflows/ci_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,17 @@ jobs:
GO_VERSION: "1.21"
outputs:
go-version: ${{ steps.set-vars.outputs.go-version }}
branch: ${{ steps.trim_ref.outputs.branch }}
steps:
- id: set-vars
- name: Set go version
id: set-vars
run: echo "go-version=${{env.GO_VERSION}}" >> "$GITHUB_OUTPUT"

- name: Trim branch name
id: trim_ref
run: |
echo "branch=$(${${{ github.ref }}:11})" >> $GITHUB_OUTPUT

# Dockerfile Linting
hadolint:
uses: celestiaorg/.github/.github/workflows/reusable_dockerfile_lint.yml@v0.2.8 # yamllint disable-line rule:line-length
Expand Down Expand Up @@ -74,6 +81,7 @@ jobs:
permissions: "write-all"
steps:
- uses: actions/checkout@v4

- name: Bump version and push tag
# Placing the if condition here is a workaround for needing to block
# on this step during workflow dispatch events but the step not
Expand All @@ -82,12 +90,10 @@ jobs:
# in goreleaser not running either.
if: ${{ github.event_name == 'workflow_dispatch' }}
uses: mathieudutour/github-tag-action@v6.1

- name: Version Release
uses: celestiaorg/.github/.github/actions/version-release@v0.2.8
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
default_bump: ${{ inputs.version }}
release_branches: ${{ needs.setup.outputs.branch }}

# Generate the release with goreleaser to include pre-built binaries
goreleaser:
Expand All @@ -99,16 +105,20 @@ jobs:
permissions: "write-all"
steps:
- uses: actions/checkout@v4

- run: git fetch --force --tags

- uses: actions/setup-go@v4
with:
go-version: ${{ needs.setup.outputs.go-version }}

- name: Import GPG key
id: import_gpg
uses: crazy-max/ghaction-import-gpg@v4
with:
gpg_private_key: ${{ secrets.GPG_SIGNING_KEY }}
passphrase: ${{ secrets.GPG_PASSPHRASE }}

# Generate the binaries and release
- uses: goreleaser/goreleaser-action@v5
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/go-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ jobs:

- name: execute test run
run: make test-unit-race
continue-on-error: true

integration_test:
needs: [lint, go_mod_tidy_check]
Expand All @@ -107,6 +108,8 @@ jobs:

- name: Swamp Tests
run: make test-swamp
continue-on-error: true

- name: Swamp Tests with Race Detector
run: make test-swamp-race
continue-on-error: true
Loading