Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to alpine 3.19 #3265

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Apr 4, 2024

Closes #3264

@rootulp rootulp self-assigned this Apr 4, 2024
@rootulp rootulp marked this pull request as ready for review April 5, 2024 17:03
@rootulp rootulp enabled auto-merge (squash) April 5, 2024 17:03
Copy link
Contributor

coderabbitai bot commented Apr 5, 2024

Walkthrough

Walkthrough

The project has updated its Dockerfiles to utilize the latest versions of Golang and Alpine Linux. Specifically, the builder image now uses Golang 1.22.2 on Alpine 3.19, and the runtime image has been upgraded to Alpine 3.19. This update ensures the project aligns with the latest, supported versions of these base images, enhancing security, performance, and compatibility.

Changes

Files Change Summary
Dockerfile, docker/.../Dockerfile_txsim, test/.../Dockerfile Updated to golang:1.22.2-alpine3.19 and alpine:3.19

Assessment against linked issues

Objective Addressed Explanation
Upgrade to Docker images to use Alpine 3.19 (#3264)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp merged commit 8d11e99 into celestiaorg:main Apr 8, 2024
34 checks passed
ARG BUILDER_IMAGE=docker.io/golang:1.22.2-alpine3.18
ARG RUNTIME_IMAGE=docker.io/alpine:3.19.1
ARG BUILDER_IMAGE=docker.io/golang:1.22.2-alpine3.19
ARG RUNTIME_IMAGE=docker.io/alpine:3.19
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting from the issue underlying this PR:

Upgrade all instances of Alpine Linux to the latest supported: 3.19.1

Here, the applied modification does not seem aligned with what has been indicated as a fix in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Docker images to use Alpine 3.19
3 participants