-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(statesync): extract app version from snapshot (backport #3871) #3936
Conversation
Closes #3818 ~~Blocked on celestiaorg/celestia-core#1477 I had to bump the celestia-core depedency to get a feature that I wanted. That implied upgrading Go and cosmos-sdk versions. ## Testing I verified that logs added in this PR show up when state syncing on Mocha. The logs show that the app version provided in the `OfferSnapshot` ABCI method was plumbed through correctly. ``` ./scripts/mocha.sh ... 2:44PM INF Offering snapshot to ABCI app format=2 hash="$�ڢ�\x1b� �zΊ\x15���`��왹\b^G:\x03+ߢޯ" height=2782000 module=statesync 2:44PM INF offering snapshot app_version=2 height=2782000 2:44PM INF mounting keys for snapshot app_version=2 ``` (cherry picked from commit 73793b9) # Conflicts: # .github/workflows/lint.yml # Makefile # docker/txsim/Dockerfile # go.mod # go.sum
Cherry-pick of 73793b9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Putting in draft, let's merge #3848 first b/c that's a portion of the diff in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just added a question about the developed tests, thanks!
Closes #3818
Blocked on celestiaorg/celestia-core#1477I had to bump the celestia-core depedency to get a feature that I wanted. That implied upgrading Go and cosmos-sdk versions.
Testing
I verified that logs added in this PR show up when state syncing on Mocha. The logs show that the app version provided in the
OfferSnapshot
ABCI method was plumbed through correctly.