Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGB Use Geth implementation of Ethereum address #528

Merged
merged 4 commits into from
Jul 13, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jul 7, 2022

@rach-id rach-id added the C: QGB label Jul 7, 2022
@rach-id rach-id self-assigned this Jul 7, 2022
@rach-id rach-id marked this pull request as draft July 7, 2022 15:11
@rach-id
Copy link
Member Author

rach-id commented Jul 7, 2022

Depends on #527

@codecov-commenter
Copy link

Codecov Report

Merging #528 (ebae2a0) into qgb-integration (458b6b2) will decrease coverage by 2.02%.
The diff coverage is 22.25%.

@@                Coverage Diff                 @@
##           qgb-integration    #528      +/-   ##
==================================================
- Coverage            11.72%   9.69%   -2.03%     
==================================================
  Files                   65      55      -10     
  Lines                10881    9384    -1497     
==================================================
- Hits                  1276     910     -366     
+ Misses                9515    8396    -1119     
+ Partials                90      78      -12     
Impacted Files Coverage Δ
e2e/qgb/qgb_network.go 0.00% <0.00%> (ø)
e2e/qgb/test_commons.go 0.00% <ø> (ø)
x/qgb/keeper/hooks.go 34.61% <ø> (+2.47%) ⬆️
x/qgb/keeper/keeper.go 74.41% <ø> (ø)
x/qgb/keeper/keeper_attestation.go 24.52% <0.00%> (ø)
x/qgb/keeper/keeper_data_commitment_confirm.go 42.85% <ø> (ø)
x/qgb/keeper/keeper_valset.go 32.00% <0.00%> (-7.51%) ⬇️
x/qgb/keeper/msg_server.go 0.00% <0.00%> (ø)
x/qgb/keeper/query_attestation.go 0.00% <ø> (ø)
x/qgb/keeper/query_general.go 0.00% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 458b6b2...ebae2a0. Read the comment docs.

@rach-id
Copy link
Member Author

rach-id commented Jul 12, 2022

Reminder: Use this commit for cosmos-sdk: 661dc726dcf247bcd01165ab94bb7c8680be7b88

@rach-id rach-id requested a review from evan-forbes July 13, 2022 18:09
@rach-id rach-id marked this pull request as ready for review July 13, 2022 18:09
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@rach-id rach-id merged commit 3d81287 into celestiaorg:qgb-integration Jul 13, 2022
@rach-id rach-id deleted the use_new_eteh_addr branch July 13, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants