Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: QGB remove EthAddress and use geth address #221

Merged
merged 4 commits into from
Jul 12, 2022
Merged

feat: QGB remove EthAddress and use geth address #221

merged 4 commits into from
Jul 12, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jul 7, 2022

Closes #143

@rach-id rach-id added the C: QGB label Jul 7, 2022
@rach-id rach-id self-assigned this Jul 7, 2022
@rach-id rach-id changed the title QGB remove EthAddress and use geth address feat: QGB remove EthAddress and use geth address Jul 7, 2022
@rach-id rach-id mentioned this pull request Jul 7, 2022
Merged
@rach-id rach-id marked this pull request as draft July 7, 2022 15:12
@rach-id rach-id marked this pull request as ready for review July 7, 2022 20:31
evan-forbes
evan-forbes approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@rach-id rach-id merged commit 661dc72 into celestiaorg:release/v0.44.x-celestia-qgb Jul 12, 2022
@rach-id rach-id deleted the use_geth_address branch July 12, 2022 16:26
rach-id added a commit to rach-id/cosmos-sdk that referenced this pull request Jul 27, 2022
@rach-id
feat: QGB remove EthAddress and use geth address (celestiaorg#221)
a6841de 
* remove EthAddress and use geth address

* adding checks on ethereum address when creating it

* fix ethereum address init when creating validator

* fix edit validator
rach-id added a commit to rach-id/cosmos-sdk that referenced this pull request Aug 4, 2022
@rach-id
feat: QGB remove EthAddress and use geth address (celestiaorg#221)
91e07ae 
* remove EthAddress and use geth address

* adding checks on ethereum address when creating it

* fix ethereum address init when creating validator

* fix edit validator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@liamsi liamsi Awaiting requested review from liamsi liamsi is a code owner

Assignees

@rach-id rach-id

Labels
C: QGB
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rach-id @evan-forbes