Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gossip txs based on priority #1069

Open
evan-forbes opened this issue Aug 31, 2023 · 2 comments
Open

Gossip txs based on priority #1069

evan-forbes opened this issue Aug 31, 2023 · 2 comments
Labels
gossiping ice-box issues are automatically assigned this label until they are planned. mempool

Comments

@evan-forbes
Copy link
Member

Currently, while mempools like CAT and v1 have the ability to reap prioritized transactions from the mempool, they add transactions to be gossiped to a queue in a FIFO way. When under high load, this could result in not being able to get a high priority transaction included as it would take too long to gossip.

The idea proposed by @musalbas was to insert the transactions in some flavor of a sorted queue. I say some flavor as there were a few different proposals to avoid the overhead of having to always maintain a separate perfectly sorted queue.

One of the suggested solutions was to utilize the existing sorted queue inside the v1 and CAT mempools. Here we would keep track of which transactions are gossiped already and iterate through the queue of sorted un-gossiped transactions periodically or after some trigger.

Another of the suggestions was to add some conditions that must be met before any form of sorting only occurred, for example large high priority transactions or some threshold of very high priority.

cmwaters pushed a commit that referenced this issue Sep 20, 2023
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@v2.7.0...v2.8.0)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@adlerjohn
Copy link
Member

Aren't the mempools constantly sorted in order to be able to drop least-priority txs in the event the mempool fills up?

@musalbas
Copy link
Member

musalbas commented Nov 1, 2023

The default max mempool size is something like 5000 transactions, so it can get quite large and exceed what can be gossiped quickly.

@evan-forbes evan-forbes added the ice-box issues are automatically assigned this label until they are planned. label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gossiping ice-box issues are automatically assigned this label until they are planned. mempool
Projects
None yet
Development

No branches or pull requests

3 participants