Add high priority broadcast routine #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we close this or is this something you want to pursue further? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a high priority broadcast routine in the v1 reactor. By implementing this as a separate routine that essentially acts as a sidecar, we attempt to avoid any invasive changes to the original mempool that may have unintended consequences that require further testing.
This creates a separate broadcast routine with a separate P2P channel that periodically every
mempoolPriorityInterval, sorts the transactions, reapsmempoolPriorityBroadcastMaxBytes, and triggers a sidecar broadcast routine in all peers.Addresses #1069