Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #1149

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Conversation

hoangdv2429
Copy link

Description

This PR will fix every typos exist on current repo. After this we can add another CI to check for typo per PR submit.

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use
    unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@hoangdv2429 hoangdv2429 mentioned this pull request Dec 11, 2023
3 tasks
@rootulp
Copy link
Collaborator

rootulp commented Dec 11, 2023

After this we can add another CI to check for typo per PR submit.

Which linter or CI check do you propose adding? This repo already enabled

- misspell

@rootulp rootulp changed the title chore(typo): fix every typos on the current repo chore: fix typos Dec 11, 2023
@hoangdv2429
Copy link
Author

Got it. I'll update to pass the check and also close the CI PR.

rootulp
rootulp previously approved these changes Dec 11, 2023
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some of these typos may exist in upstream https://github.com/cometbft/cometbft if you'd like to make a similar PR there

Thanks for your contribution!

privval/msgs_test.go Outdated Show resolved Hide resolved
Co-authored-by: Rootul P <rootulp@gmail.com>
@rootulp
Copy link
Collaborator

rootulp commented Dec 11, 2023

IMO we should ignore the failing govulncheck on this PR and instead tackle separately in #1151

@rootulp rootulp enabled auto-merge (squash) December 11, 2023 15:50
@hoangdv2429
Copy link
Author

`=== Informational ===

Found 2 vulnerabilities in packages that you import, but there are no call
stacks leading to the use of these vulnerabilities. You may not need to
take any action. See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck
for details.

Vulnerability #1: GO-2023-2186
Incorrect detection of reserved device names on Windows in path/filepath
More info: https://pkg.go.dev/vuln/GO-2023-2186
Standard library
Found in: path/filepath@go1.21.3
Fixed in: path/filepath@go1.21.4

Vulnerability #2: GO-2023-2102
HTTP/2 rapid reset can cause excessive work in net/http
More info: https://pkg.go.dev/vuln/GO-2023-2102
Module: golang.org/x/net
Found in: golang.org/x/net@v0.14.0
Fixed in: golang.org/x/net@v0.17.0

Your code is affected by 2 vulnerabilities from the Go standard library.`
Yes, I agree. Seems like we need to bump those deps.

@hoangdv2429
Copy link
Author

The failing check could be from json or toml. Please let's me check.

@hoangdv2429
Copy link
Author

@rootulp Can you rerun the e2e test sir, I don't think I touch any config files

@rootulp
Copy link
Collaborator

rootulp commented Dec 11, 2023

@rootulp Can you rerun the e2e test sir, I don't think I touch any config files

Thanks for the ping! Sorry the CI on this repo is flakey. Re-running.

@rootulp rootulp requested review from staheri14 and removed request for adlerjohn and evan-forbes December 13, 2023 04:43
@rootulp rootulp merged commit 34b83b5 into celestiaorg:main Dec 13, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants