Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/ci typo check #1150

Closed
wants to merge 3 commits into from

Conversation

hoangdv2429
Copy link

@hoangdv2429 hoangdv2429 commented Dec 11, 2023

Description

This PR will add CI check for typo per PR submit or push to main. #1149 should be merge before this one.

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use
    unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@hoangdv2429
Copy link
Author

Close as there is already another CI for checking this.

@rootulp
Copy link
Collaborator

rootulp commented Dec 11, 2023

Thanks for working on this! Agreed we should try to use golangci-lint's linters if possible rather than adding a new one. If we learn that golangci-lint's typo identification isn't as capable as other linters then we can consider adopting a different one.

Ideally a new spelling linter also uses Go instead of Python / Pip so that maintainers don't have to set up more dependencies prior to checking for spelling locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants