Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rsmt tree wrapper for nmt #238
Implement rsmt tree wrapper for nmt #238
Changes from 2 commits
cf34016
3b59269
445cf89
66fb1ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that when celestiaorg/nmt#27 lands, and if we attach the parity nID when calling Push, then this method can be simplified to just calling push on the underlying NMT, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we will still need a wrapper, because
rsmt2d.RepairExtendedDatasquare
is not aware of how we erasure namespaces andNamespacedMerkleTree
would always assume that the first 8 bytes is the namespace. Now that we're erasuring namespaces, the first 8 bytes of the the 2nd half of the tree is not a namespace, it's just erasure data.nmt.Push
would panic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might still be missing something but why can't the caller of the NMT do the "preprocessing" and add the parity namespace in front of the parity shares (basically the same thing the wrapper currently does)? The tree (wrapper) would then not need any counter bc the calling code already knows when the erasured part starts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do that in lazyledger-core, but we would also have to do that in
rsmt2d.RepairDataSquare
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see now. Thanks 🙏