Change Push signature and simplify PrefixedData #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 94.82% 94.70% -0.13%
==========================================
Files 7 7
Lines 309 302 -7
==========================================
- Hits 293 286 -7
Misses 11 11
Partials 5 5
Continue to review full report at Codecov.
|
liamsi
force-pushed
the
ismail/refactor_push
branch
from
0857ae0
to
a98611c
Compare
liamsi
force-pushed
the
ismail/refactor_push
branch
from
a98611c
to
59ac120
Compare
evan-forbes
reviewed
Mar 22, 2021
fuzz_test.go
Outdated
| err := tree.Push(d[:size], d[size:]) | ||
| err := tree.Push(d[:size]) |
There was a problem hiding this comment.
does this test only need namespaces now?
There was a problem hiding this comment.
Nope, good catch! Fixed in 1feed0c
evan-forbes
approved these changes
Mar 22, 2021
liamsi
added a commit
that referenced
this pull request
Mar 22, 2021
liamsi
added a commit
that referenced
this pull request
Mar 23, 2021
liamsi
added a commit
that referenced
this pull request
Mar 25, 2021
Fix minor refactoring glitch introduced with #27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Push method to take in the pair (nid, data) as one argument.
closes: #26