Fix minor refactoring glitch introduced with #27 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
liamsi
changed the title
|
Whoops, we might have missed another one at https://github.com/lazyledger/nmt/blob/2ce94e57fee491ef48a324222ce2149c3a2b7314/nmt_test.go#L489 just triple checked, so that should be the last of them. |
|
Meh, I thought I've gone through each call of Thanks again, Evan! Force pushed both single-line changes into 6cb8085 |
liamsi
force-pushed
the
ismail/minor_fix
branch
from
2ce94e5
to
6cb8085
Compare
Wondertan
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes another minor glitch that was introduced by changing the Push method signature in #27. Similar to what @evan-forbes found in #27 (comment)
Followup to / part of #26.