Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update go-libp2p to v0.24.0 #1029

Closed
Wondertan opened this issue Aug 19, 2022 · 4 comments · Fixed by #1547
Closed

deps: update go-libp2p to v0.24.0 #1029

Wondertan opened this issue Aug 19, 2022 · 4 comments · Fixed by #1547
Assignees

Comments

@Wondertan
Copy link
Member

Wondertan commented Aug 19, 2022

There is a new release that merges go-libp2p-core into go-libp2p. We rely on go-libp2p-core in multiple places, so updating will require multiple reimports and some efforts. All the related libp2p deps should be updated as well, e.g pubsub

https://github.com/libp2p/go-libp2p/releases/tag/v0.22.0

@Wondertan
Copy link
Member Author

We should wait for libp2p/go-libp2p-pubsub#498

@Wondertan
Copy link
Member Author

The above one is done, but we should also wait for libp2p/go-libp2p-kad-dht#788 and ipfs/go-bitswap#580

@distractedm1nd
Copy link
Member

@Wondertan reminder that the mentioned PRs are merged

@Wondertan
Copy link
Member Author

Thanks, @distractedm1nd. Not big a prio, for now, to jump on this.

Also, we know from #1035 that the newest version of bitswap will cause us flakiness, and updating would require fixing those and CI as an additional burden

@Wondertan Wondertan changed the title deps: update go-libp2p to v0.22.0 deps: update go-libp2p to v0.24.0 Dec 15, 2022
Wondertan added a commit that referenced this issue Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants