Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share: unify and move share.MaxSquareSize and ipld.MaxSquareSize to share/eds #2309

Closed
Wondertan opened this issue Jun 2, 2023 · 0 comments · Fixed by #2388
Closed

share: unify and move share.MaxSquareSize and ipld.MaxSquareSize to share/eds #2309

Wondertan opened this issue Jun 2, 2023 · 0 comments · Fixed by #2388
Labels
good first issue Good for newcomers

Comments

@Wondertan
Copy link
Member

Wondertan commented Jun 2, 2023 •
edited
Loading

We have defined the constant in the two places, and while there is an eds package which is logically better suited for it.
@Wondertan Wondertan added the good first issue Good for newcomers label Jun 2, 2023
@Wondertan Wondertan mentioned this issue Jun 2, 2023
Merged
5 tasks
@Wondertan Wondertan mentioned this issue Jun 23, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 27, 2023
@Wondertan
refactor!(share): integrate new Namespace type (#2388)
ccae150 
## Notable Changes
- `namespace.ID` to  `share.Namespace`
- Changes every comment namespace ID mentioning to just namespace. I
renamed every such mention besides in ADRs. I don't want to touch ADRs
here, as they need a more holistic re-review and up-to-date catchup.
	- Uses all the utility methods on the type, where suitable
- Namespace constructor now only creates Blob Namespaces. For other
reserved namespaces, the predefined globals should be used.
- Uses namespace.ValidateDataNamespace everywhere data is requested.
This is guarantees we verify the namespace are 100% valid and forbids
requesting parity and padding namespaces.
- Restricts PFBs for reserved namespaces 
- Reversed the dependency from `share -> share/ipld` to `share/ipld ->
share`
- NewBlobV0 constructor. Similar to NewNamespaceV0
- `sharetest` pkg for share related testing utilities
- `edstest` pkg for eds related testing utilities

## Follow-ups
- `blobtest` pkg to generate node's blob type


## Refs
* Substitutes zombie PR
#2376. I push to the
branch, but GH does not see commits.
* Based on #2367
* Closes #2301
* Closes #2309 
* Blocked on #2256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!(share): integrate new Namespace type celestiaorg/celestia-node
1 participant
@Wondertan