refactor!(share): integrate new Namespace type #2376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # share/get_test.go # share/ipld/get.go # share/ipld/namespace_data.go
Wondertan
added
area:shares
Wondertan
changed the title
Wondertan
commented
Jun 16, 2023
| @@ -20,7 +19,7 @@ const ( | |||
| namespacedDataEndpoint = "/namespaced_data" | |||
| ) | |||
|
|
|||
| var nIDKey = "nid" | |||
There was a problem hiding this comment.
Forgot to change the actual string and it's breaking....
Don't have processing power rn to assess whether this worth a breakage here or not
There was a problem hiding this comment.
We are not deprecating this, so it might be worth it. Does it need changes besides go-cnc?
Wondertan
force-pushed
the
hlib/share/namespace-integration
branch
from
1854a3a
to
7bcece5
Compare
Wondertan
changed the title
…on' into hlib/share/namespace-integration
|
Currently contains all the changes from #2256 to check that all the tests are passing with it. |
5 tasks
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd and
walldiss
as code owners
|
Closed in favor of #2388. GH does not see new commits. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
## Notable Changes - `namespace.ID` to `share.Namespace` - Changes every comment namespace ID mentioning to just namespace. I renamed every such mention besides in ADRs. I don't want to touch ADRs here, as they need a more holistic re-review and up-to-date catchup. - Uses all the utility methods on the type, where suitable - Namespace constructor now only creates Blob Namespaces. For other reserved namespaces, the predefined globals should be used. - Uses namespace.ValidateDataNamespace everywhere data is requested. This is guarantees we verify the namespace are 100% valid and forbids requesting parity and padding namespaces. - Restricts PFBs for reserved namespaces - Reversed the dependency from `share -> share/ipld` to `share/ipld -> share` - NewBlobV0 constructor. Similar to NewNamespaceV0 - `sharetest` pkg for share related testing utilities - `edstest` pkg for eds related testing utilities ## Follow-ups - `blobtest` pkg to generate node's blob type ## Refs * Substitutes zombie PR #2376. I push to the branch, but GH does not see commits. * Based on #2367 * Closes #2301 * Closes #2309 * Blocked on #2256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Based on #2367
Closes #2301
Blocked on #2256 (because new rules on namespaces in existing tests cause to trigger not found within namespace range path logic, which we don't handle yet)