Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: submitPFB endpoint should return tx hash #2328

Closed
Wondertan opened this issue Jun 6, 2023 · 0 comments · Fixed by #2329
Closed

gateway: submitPFB endpoint should return tx hash #2328

Wondertan opened this issue Jun 6, 2023 · 0 comments · Fixed by #2329
Assignees
Labels
kind:break! Attached to breaking PRs

Comments

@Wondertan
Copy link
Member

In case we fail to submit PFB, we still get the non-nil response and can access the TxHash field from it, which we can return together with error.

Note that this breaks the API and go-cnc will have to be updated as well to support it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:break! Attached to breaking PRs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants