Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!feat(api/gateway): return txdata from submitPFB if it is present #2329

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Jun 6, 2023

Overview

Closes #2328

@walldiss walldiss added kind:feat Attached to feature PRs area:api Related to celestia-node API labels Jun 6, 2023
@walldiss walldiss self-assigned this Jun 6, 2023
@walldiss walldiss changed the title feat(api/gateway): return txdata from submitPFB if it is present !feat(api/gateway): return txdata from submitPFB if it is present Jun 6, 2023
api/gateway/state.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #2329 (7940278) into main (dd1a019) will increase coverage by 0.18%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #2329      +/-   ##
==========================================
+ Coverage   50.62%   50.81%   +0.18%     
==========================================
  Files         154      154              
  Lines        9736     9739       +3     
==========================================
+ Hits         4929     4949      +20     
+ Misses       4381     4354      -27     
- Partials      426      436      +10     
Impacted Files Coverage Δ
api/gateway/state.go 10.88% <75.00%> (+10.88%) ⬆️

... and 4 files with indirect coverage changes

@Wondertan Wondertan added the kind:break! Attached to breaking PRs label Jun 6, 2023
@walldiss walldiss enabled auto-merge (squash) June 6, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Related to celestia-node API kind:break! Attached to breaking PRs kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gateway: submitPFB endpoint should return tx hash
4 participants