Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(nodebuilder/blob): Blob module needs to be able to take a stubbed state module as Submitter #3244

Closed
renaynay opened this issue Mar 7, 2024 · 0 comments · Fixed by #3254
Closed

bug(nodebuilder/blob): Blob module needs to be able to take a stubbed state module as Submitter #3244

renaynay opened this issue Mar 7, 2024 · 0 comments · Fixed by #3254
Assignees
@vgonkivs
Labels
area:blob area:state Related to fetching state and state execution bug Something isn't working

Comments

@renaynay
Copy link
Member

renaynay commented Mar 7, 2024

Currently, if no core endpoint is provided and the blob module is used for blob submission, we get nasty errors from RPC:

panic in rpc method 'blob.Submit': runtime error: invalid memory address or nil pointer dereference

It doesn't crash the node, but it's not clean. Use stubbed state module instead for cleaner err.
@renaynay renaynay added bug Something isn't working area:state Related to fetching state and state execution area:blob labels Mar 7, 2024
@vgonkivs vgonkivs mentioned this issue Mar 13, 2024
Merged
Wondertan pushed a commit that referenced this issue Mar 13, 2024
@vgonkivs
fix(nodebuilder/blob): use state module instead of the state accessor…
3b279bc 
… in the module construction (#3254)

Resolves #3244
renaynay pushed a commit to renaynay/celestia-node that referenced this issue Apr 3, 2024
@vgonkivs @renaynay
fix(nodebuilder/blob): use state module instead of the state accessor…
c77eae0 
… in the module construction (celestiaorg#3254)

Resolves celestiaorg#3244
renaynay pushed a commit to renaynay/celestia-node that referenced this issue Apr 3, 2024
@vgonkivs @renaynay
fix(nodebuilder/blob): use state module instead of the state accessor…
4747985 
… in the module construction (celestiaorg#3254)

Resolves celestiaorg#3244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vgonkivs vgonkivs

Labels
area:blob area:state Related to fetching state and state execution bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@vgonkivs @renaynay