Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodebuilder/blob): use state module instead of the state accessor in the module construction #3254

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

vgonkivs
Copy link
Member

Resolves #3244

@vgonkivs vgonkivs added kind:fix Attached to bug-fixing PRs area:blob labels Mar 13, 2024
@vgonkivs vgonkivs self-assigned this Mar 13, 2024
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The art of FX

@Wondertan Wondertan enabled auto-merge (squash) March 13, 2024 11:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.80%. Comparing base (c1ab9c5) to head (ad9c0a3).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3254      +/-   ##
==========================================
- Coverage   52.08%   44.80%   -7.28%     
==========================================
  Files         183      265      +82     
  Lines       11594    14620    +3026     
==========================================
+ Hits         6039     6551     +512     
- Misses       5043     7315    +2272     
- Partials      512      754     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wondertan Wondertan merged commit 3b279bc into celestiaorg:main Mar 13, 2024
24 checks passed
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Apr 3, 2024
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(nodebuilder/blob): Blob module needs to be able to take a stubbed state module as Submitter
5 participants