Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump golanci-lint workflow #2641

Merged
merged 2 commits into from
Sep 4, 2023
Merged

chore(deps): bump golanci-lint workflow #2641

merged 2 commits into from
Sep 4, 2023

Conversation

distractedm1nd
Copy link
Collaborator

Self explanatory. The reason for the fix in core_accessor was an implicit memory aliasing. It was taking the address of the loop variable, which doesn't change in between iterations ofc, so the every blob pointed to the last blob

@distractedm1nd distractedm1nd added kind:deps Pull requests that update a dependency file kind:chore labels Aug 31, 2023
@distractedm1nd distractedm1nd self-assigned this Aug 31, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2641 (072afd7) into main (47047f3) will decrease coverage by 0.23%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #2641      +/-   ##
==========================================
- Coverage   51.34%   51.11%   -0.23%     
==========================================
  Files         158      158              
  Lines       10559    10559              
==========================================
- Hits         5421     5397      -24     
- Misses       4669     4687      +18     
- Partials      469      475       +6     
Files Changed Coverage Δ
cmd/celestia/rpc.go 17.85% <ø> (ø)
nodebuilder/config.go 44.44% <0.00%> (ø)
state/core_access.go 35.32% <66.66%> (ø)

... and 7 files with indirect coverage changes

@distractedm1nd distractedm1nd merged commit 9ff98c4 into main Sep 4, 2023
16 of 18 checks passed
@distractedm1nd distractedm1nd deleted the golangci-bump branch September 4, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:chore kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants