chore(deps): bump golanci-lint workflow

.github/workflows/go-ci.yml

@@ -25,7 +25,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3.6.0
         with:
-          version: v1.52.2
+          version: v1.54.2
 
   go_mod_tidy_check:
     name: Go Mod Tidy Check

.golangci.yml

@@ -4,7 +4,7 @@ run:
 linters:
   enable:
     - bodyclose
-    - depguard
+     # - depguard as of v1.54.2, the default config throws errors on our repo
     - dogsled
     - dupl
     - errcheck

cmd/celestia/rpc.go

@@ -23,7 +23,7 @@ import (
 	"github.com/celestiaorg/celestia-node/state"
 )
 
-const authEnvKey = "CELESTIA_NODE_AUTH_TOKEN"
+const authEnvKey = "CELESTIA_NODE_AUTH_TOKEN" //nolint:gosec
 
 var requestURL string
 var authTokenFlag string

nodebuilder/config.go

@@ -114,15 +114,15 @@ func removeConfig(path string) error {
 func UpdateConfig(tp node.Type, path string) (err error) {
 	path, err = storePath(path)
 	if err != nil {
-		return
+		return err
 	}
 
 	flock, err := fslock.Lock(lockPath(path))
 	if err != nil {
 		if err == fslock.ErrLocked {
 			err = ErrOpened
 		}
-		return
+		return err
 	}
 	defer flock.Unlock() //nolint: errcheck
 
@@ -131,18 +131,18 @@ func UpdateConfig(tp node.Type, path string) (err error) {
 	cfgPath := configPath(path)
 	cfg, err := LoadConfig(cfgPath)
 	if err != nil {
-		return
+		return err
 	}
 
 	cfg, err = updateConfig(cfg, newCfg)
 	if err != nil {
-		return
+		return err
 	}
 
 	// save the updated config
 	err = removeConfig(cfgPath)
 	if err != nil {
-		return
+		return err
 	}
 	return SaveConfig(cfgPath, cfg)
 }

state/core_access.go

@@ -195,11 +195,11 @@ func (ca *CoreAccessor) SubmitPayForBlob(
 	}
 
 	appblobs := make([]*apptypes.Blob, len(blobs))
-	for i, b := range blobs {
-		if err := b.Namespace().ValidateForBlob(); err != nil {
+	for i := range blobs {
+		if err := blobs[i].Namespace().ValidateForBlob(); err != nil {
 			return nil, err
 		}
-		appblobs[i] = &b.Blob
+		appblobs[i] = &blobs[i].Blob
 	}
 
 	// we only estimate gas if the user wants us to (by setting the gasLim to 0). In the future we may