-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ci) update github actions ci to use a single GO_VERSION variable #2806
Conversation
…s to all other workflows and steps
Codecov Report
@@ Coverage Diff @@
## main #2806 +/- ##
==========================================
+ Coverage 51.57% 51.81% +0.24%
==========================================
Files 167 167
Lines 10787 10787
==========================================
+ Hits 5563 5589 +26
+ Misses 4735 4706 -29
- Partials 489 492 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Beside not skipping for dependabot this lgtm.
This is a good workaround not having global env in the actions. The alternative would be to set a secret but then we can't actually see the version, so this is better.
cc @celestiaorg/devops for visibility and helping to reapply elsewhere.
had to resolve conflict on this |
This sets a single variable (
GO_VERSION
) in the mainci.yml
workflow, which will be the single place we set the current go version. We then run asetup
job that sets an required output for subsequent jobs to use, adding:Where we had previously either:
1.21
or whatever go version explicitlyWhen the rpc openrpc.json workflow check changes are merged, this will also prevent another duplication of the go version appearing.
refs #2698