Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ci) update github actions ci to use a single GO_VERSION variable #2806

Merged
merged 6 commits into from
Oct 30, 2023
Merged

(ci) update github actions ci to use a single GO_VERSION variable #2806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
14d4085
update ci to use a single GO_VERSION variable and pass that as output…
ramin Oct 4, 2023
11848a9
version more specific
ramin Oct 4, 2023
01ea117
go-ci dependent on setup
ramin Oct 4, 2023
9e19dfd
remove accidental inclusion of dependabot check in ci_release.yml setup
ramin Oct 4, 2023
53a5555
Merge branch 'main' into ci/ramin/go-variable
ramin Oct 23, 2023
15b3f6d
Merge branch 'main' into ci/ramin/go-variable
ramin Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/ci_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ on:
- "v*"
pull_request:
workflow_dispatch:
# Inputs the workflow accepts.
inputs:
version:
# Friendly description to be shown in the UI instead of 'name'
Expand All @@ -23,6 +22,20 @@ on:
- major

jobs:
# set up go version for use through pipelines, setting
# variable one time and setting outputs to access passing it
# to other jobs
setup:
runs-on: ubuntu-latest
env:
# upgrade go version throughout pipeline here
GO_VERSION: "1.21"
outputs:
go-version: ${{ steps.set-vars.outputs.go-version }}
steps:
- id: set-vars
run: echo "go-version=${{env.GO_VERSION}}" >> "$GITHUB_OUTPUT"

# Dockerfile Linting
hadolint:
uses: celestiaorg/.github/.github/workflows/reusable_dockerfile_lint.yml@v0.2.8 # yamllint disable-line rule:line-length
Expand All @@ -48,7 +61,10 @@ jobs:
markdownlint --config .markdownlint.yaml '**/*.md'

go-ci:
needs: setup
uses: ./.github/workflows/go-ci.yml
with:
go-version: ${{ needs.setup.outputs.go-version }}

# If this was a workflow dispatch event, we need to generate and push a tag
# for goreleaser to grab
Expand Down Expand Up @@ -86,7 +102,7 @@ jobs:
- run: git fetch --force --tags
- uses: actions/setup-go@v4
with:
go-version: 1.21
go-version: ${{ needs.setup.outputs.go-version }}
- name: Import GPG key
id: import_gpg
uses: crazy-max/ghaction-import-gpg@v4
Expand Down
18 changes: 10 additions & 8 deletions .github/workflows/go-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ name: Go CI

on:
workflow_call:

env:
GO_VERSION: '1.21'
inputs:
go-version:
description: 'Go version'
required: true
type: string

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand All @@ -20,7 +22,7 @@ jobs:

- uses: actions/setup-go@v4
with:
go-version: ${{ env.GO_VERSION }}
go-version: ${{ inputs.go-version }}

- name: golangci-lint
uses: golangci/golangci-lint-action@v3.7.0
Expand All @@ -38,7 +40,7 @@ jobs:

- uses: actions/setup-go@v4
with:
go-version: ${{ env.GO_VERSION }}
go-version: ${{ inputs.go-version }}

- run: go mod tidy

Expand All @@ -61,7 +63,7 @@ jobs:
- name: set up go
uses: actions/setup-go@v4
with:
go-version: ${{ env.GO_VERSION }}
go-version: ${{ inputs.go-version }}

- name: run unit tests
run: make test-unit
Expand All @@ -85,7 +87,7 @@ jobs:
- name: set up go
uses: actions/setup-go@v4
with:
go-version: ${{ env.GO_VERSION }}
go-version: ${{ inputs.go-version }}

- name: execute test run
run: make test-unit-race
Expand All @@ -101,7 +103,7 @@ jobs:
- name: set up go
uses: actions/setup-go@v4
with:
go-version: ${{ env.GO_VERSION }}
go-version: ${{ inputs.go-version }}

- name: Swamp Tests
run: make test-swamp
Expand Down
Loading