Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/listener): make listener to retry subscribing on errors #2876

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix(core/listener): make listener to retry subscribing on errors #2876

merged 1 commit into from
Oct 26, 2023

Conversation

walldiss
Copy link
Member

Resolves #2875

@walldiss walldiss added area:core_and_app Relationship with Core node and Celestia-App kind:fix Attached to bug-fixing PRs labels Oct 26, 2023
@walldiss walldiss self-assigned this Oct 26, 2023
@walldiss walldiss changed the title fix(core/listener): make listener retry to subscribe on errors fix(core/listener): make listener to retry subscribing on errors Oct 26, 2023
@walldiss walldiss mentioned this pull request Oct 26, 2023
Merged
@codecov-commenter
Copy link

Codecov Report

Merging #2876 (ce836fd) into main (565691f) will increase coverage by 0.13%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2876      +/-   ##
==========================================
+ Coverage   51.57%   51.70%   +0.13%     
==========================================
  Files         167      167              
  Lines       10787    10798      +11     
==========================================
+ Hits         5563     5583      +20     
+ Misses       4735     4721      -14     
- Partials      489      494       +5
Files Coverage Δ
core/listener.go 48.80% <0.00%> (-4.71%) ⬇️

... and 10 files with indirect coverage changes

@renaynay
Copy link
Member

Ideally should test though

@renaynay renaynay merged commit 6a1e804 into celestiaorg:main Oct 26, 2023
16 of 20 checks passed
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay renaynay approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

Assignees

@walldiss walldiss

Labels
area:core_and_app Relationship with Core node and Celestia-App kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(core/listener): Listener should retry subscribing on error
4 participants
@walldiss @codecov-commenter @renaynay @Wondertan