node: enhance DI allowing overriding of dependencies #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
reviewed
Dec 22, 2021
renaynay
previously approved these changes
Dec 23, 2021
…rrideSupply option
…de in favour of custom lifecycle funcs
…ke options errorable
Wondertan
force-pushed
the
hlib/fxutil
branch
from
f7fc85b
to
1f6dc4a
Compare
… if upstream issue is fixed
Bidon15
previously approved these changes
Dec 24, 2021
renaynay
approved these changes
Dec 24, 2021
Bidon15
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This is a solution for #285. It is different from the design there, as it's not possible. Finding the other solution took a lot of time, sketching, and learning. The reason why is the limitation of FX described in uber-go/fx#825. This PR solves the problem by extending
fxutillib to mimicfxfunctionality + newOverrideSupplyoption described in uber-go/fx#825. In future, the code offxutilmight be deleted once the describedfxfeature is implemented and merged.This PR might be difficult to understand in detail as it involves reflection + understanding of the DI itself, but also a good opportunity to understand how both worlds work for the implementer and for the reviewers.
Changes
fxutilmimicingfxoptions with more new additionalsOverrideSupplySupplyAsProvideAsfx.Appfrom Node