feat(node): extract overrides from Config into Settings #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
reviewed
Dec 20, 2021
This was referenced Dec 20, 2021
renaynay
previously approved these changes
Dec 24, 2021
There was a problem hiding this comment.
I'm good with this as long as @adlerjohn 's comments are addressed.
Wondertan
force-pushed
the
hlib/fxutil
branch
from
f7fc85b
to
1f6dc4a
Compare
Wondertan
force-pushed
the
hlib/node-settings
branch
from
c464f85
to
8a6e5a7
Compare
renaynay
approved these changes
Dec 24, 2021
Bidon15
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
#290 adds Component overriding options to
nodeand applies those onto Config. This is confusing and this PRs aims to fix this by introducingnode.settings.