Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go.mod): bump go-header #3052

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Conversation

renaynay
Copy link
Member

Bumps go-header to the latest RC to pull in the fix to the peerTracker in celestiaorg/go-header#139. It's suspected that the peerTracker's aggressive scoring mechanism is causing header syncing to stall after periods of poor connectivity.

@renaynay renaynay added the kind:deps Pull requests that update a dependency file label Dec 22, 2023
@renaynay renaynay self-assigned this Dec 22, 2023
ramin
ramin previously approved these changes Dec 22, 2023
Copy link
Contributor

@ramin ramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

walldiss
walldiss previously approved these changes Dec 22, 2023
@renaynay renaynay marked this pull request as draft December 22, 2023 12:54
@renaynay
Copy link
Member Author

I forgot metrics broke in this bump

@renaynay renaynay dismissed stale reviews from walldiss and ramin via 78b8557 December 23, 2023 16:36
@renaynay renaynay marked this pull request as ready for review December 23, 2023 16:37
@renaynay renaynay requested a review from ramin December 23, 2023 16:37
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (77cc973) 51.19% compared to head (675a88b) 50.99%.

Files Patch % Lines
nodebuilder/header/constructors.go 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3052      +/-   ##
==========================================
- Coverage   51.19%   50.99%   -0.21%     
==========================================
  Files         177      177              
  Lines       11148    11147       -1     
==========================================
- Hits         5707     5684      -23     
- Misses       4942     4960      +18     
- Partials      499      503       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as Vlad

@ramin ramin enabled auto-merge (squash) January 2, 2024 11:59
@ramin ramin merged commit b97175c into celestiaorg:main Jan 2, 2024
17 of 19 checks passed
renaynay added a commit to renaynay/celestia-node that referenced this pull request Jan 15, 2024
Bumps go-header to the latest RC to pull in the fix to the `peerTracker`
in celestiaorg/go-header#139. It's suspected
that the `peerTracker`'s aggressive scoring mechanism is causing header
syncing to stall after periods of poor connectivity.

---------

Co-authored-by: ramin <raminkeene@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants