feat(peer-tracker): add minAmount of peers tracked in tracker #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
tzdybal,
renaynay,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 63.60% 63.71% +0.11%
==========================================
Files 39 39
Lines 3366 3382 +16
==========================================
+ Hits 2141 2155 +14
- Misses 1060 1061 +1
- Partials 165 166 +1 ☔ View full report in Codecov by Sentry. |
renaynay
previously approved these changes
Dec 20, 2023
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
renaynay
approved these changes
Dec 21, 2023
ramin
approved these changes
Dec 21, 2023
ramin
added a commit
to celestiaorg/celestia-node
that referenced
this pull request
Jan 2, 2024
Bumps go-header to the latest RC to pull in the fix to the `peerTracker` in celestiaorg/go-header#139. It's suspected that the `peerTracker`'s aggressive scoring mechanism is causing header syncing to stall after periods of poor connectivity. --------- Co-authored-by: ramin <raminkeene@gmail.com>
renaynay
added a commit
to renaynay/celestia-node
that referenced
this pull request
Jan 15, 2024
Bumps go-header to the latest RC to pull in the fix to the `peerTracker` in celestiaorg/go-header#139. It's suspected that the `peerTracker`'s aggressive scoring mechanism is causing header syncing to stall after periods of poor connectivity. --------- Co-authored-by: ramin <raminkeene@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
minPeerTrackerSizeBeforeGCsetting to peer tracker, that specifies the min amount of peers before the peerTracker starts removing peers.