refactor(blob)!: replace SubmitOptions with a GasPrice parameter

[distractedm1nd]

This PR modifies the blob interface to replace SubmitOptions with GasLimit. The reasoning here is that setting a gas price is a lot more intuitive/easier than calculating the fee and gas limit, which take cosmossdk and celestia-app imports to calculate without much effort. Related: rollkit/go-da#30

Based on a suggestion from @vgonkivs we alias float64 to be able to provide a default value, but now that its there I think we can just have float64 and the same constructor, as it doesn't change that much.

Breaks the API, cc @jcstein, @tuxcanfly, and @Ferret-san .

Closes #3053.

[vgonkivs]

What has happened with the order of gomock import in /mocks/?

[distractedm1nd]

What has happened with the order of gomock import in /mocks/?

It looks like this is now correct, but I'm also not sure

[codecov-commenter]

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (7bf9713) 51.96% compared to head (92211be) 51.85%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
blob/service.go	0.00%	11 Missing ⚠️
libs/pidstore/pidstore.go	76.92%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3094      +/-   ##
==========================================
- Coverage   51.96%   51.85%   -0.12%     
==========================================
  Files         178      178              
  Lines       11206    11226      +20     
==========================================
- Hits         5823     5821       -2     
- Misses       4888     4906      +18     
- Partials      495      499       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rootulp]

I agree with the goal of making this path easier to use. IMO a user shouldn't have to explicitly specify their gas price, gas limit, or fee.

1. If a user doesn't specify their gas price, the default gas price of .002 should be used.
2. If a user doesn't specify their gas limit, one is estimated based on the transaction contents (i.e. blob sizes)
3. If a user doesn't specify their fee, it is calculated based on fee = gasPrice * gasLimit.

[Wondertan]

utACK

[renaynay]

also utack

[musalbas]

If we're removing the ability to set gas limit, we need to be 100% the gas limit estimate is correct, as I have heard reports from teams that the estimated gas limit is lower than it actually should be. This is why wallets like Keplr multiply gas limit estimates 1.2x

[jcstein]

has this been tested?

[jcstein]

I just did and it worked for me

celestia version
export NODE_STORE=$HOME/.celestia-light-mocha-4
celestia blob submit 0x6B656B 'kek' --gas.price 0.0069 --node.store $NODE_STORE
Semantic version: v0.13.0
Commit: e55e1c88708b46839867bcbbed9bcdd8a3ffa830
Build Date: Wed Feb  7 19:32:07 EST 2024
System version: arm64/darwin
Golang version: go1.21.1
{
  "result": {
    "height": 1126617,
    "commitment": "cjtmIuILvB4ItexsJoHux/G6Yp15w6YmpSbXkSlS2ZE="
  }
}

celenium link to tx

[jcstein]

however, i'm not sure if this is accurate?

[jcstein]

How does this apply to the remainder of methods? context in this issue #3174