-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: document --gas.price
flag
#1403
Conversation
WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- developers/node-tutorial.md (1 hunks)
Additional comments: 1
developers/node-tutorial.md (1)
- 791-794: The example command for submitting a blob with a specified gas price correctly demonstrates the usage of the
--gas-price
flag. However, the preceding text contains a typo in the gas price value, which could confuse readers.
fixes flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- developers/node-tutorial.md (1 hunks)
Additional comments: 3
developers/node-tutorial.md (3)
- 778-787: The introduction of the
--gas-price
flag and its default behavior is clear. However, ensure that the documentation elsewhere (not in the provided diff) also reflects this change, especially in sections that previously referenced the now-replaced--fee
and--gas.limit
flags.- 789-789: The link to learn more about gas fees and limits should be verified to ensure it leads to updated content reflecting the new
--gas-price
flag.- 791-794: The example command for setting a higher gas price using the
--gas.price
flag is correct and demonstrates the intended usage well. Ensure that examples like this are consistently updated across all relevant documentation sections.
Overview
This documents celestiaorg/celestia-node#3094
Checklist
Summary by CodeRabbit
celestia
CLI. The--fee
and--gas.limit
flags have been replaced by a single--gas-price
flag. Gas limit calculation now depends on submitted data size.