misc(header/headertest): Rename param for test suite to be more clear #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3137 +/- ##
==========================================
+ Coverage 51.64% 51.93% +0.28%
==========================================
Files 178 178
Lines 11226 11226
==========================================
+ Hits 5798 5830 +32
+ Misses 4933 4898 -35
- Partials 495 498 +3 ☔ View full report in Codecov by Sentry. |
ramin
approved these changes
Jan 24, 2024
|
wut |
|
@Wondertan I always assumed the test suite would take |
|
There is a comment that clearly states that this is validators, I don't think chaing var name is needed |
|
Now part of #3139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry but this was bothering me.