Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(header/headertest): Enable block time intervals for header generation #3139

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

renaynay
Copy link
Member

Header test suite can now generate headers with the given block time interval if it is specified.

Needed for testing pruner service.

@renaynay renaynay added area:header Extended header kind:misc Attached to miscellaneous PRs labels Jan 26, 2024
@renaynay renaynay self-assigned this Jan 26, 2024
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, including this numValidators thingy in different pr is smart. The change makes sense as well

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (debad37) 51.64% compared to head (004f177) 51.92%.

Files Patch % Lines
header/headertest/testing.go 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3139      +/-   ##
==========================================
+ Coverage   51.64%   51.92%   +0.27%     
==========================================
  Files         178      178              
  Lines       11226    11231       +5     
==========================================
+ Hits         5798     5832      +34     
+ Misses       4933     4903      -30     
- Partials      495      496       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramin ramin enabled auto-merge (squash) March 5, 2024 11:33
@ramin ramin merged commit f843183 into celestiaorg:main Mar 5, 2024
33 of 39 checks passed
renaynay added a commit to renaynay/celestia-node that referenced this pull request Apr 3, 2024
…ation (celestiaorg#3139)

Header test suite can now generate headers with the given block time
interval if it is specified.

Needed for testing pruner service.
renaynay added a commit to renaynay/celestia-node that referenced this pull request Apr 3, 2024
…ation (celestiaorg#3139)

Header test suite can now generate headers with the given block time
interval if it is specified.

Needed for testing pruner service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:header Extended header kind:misc Attached to miscellaneous PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants