Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain normal Merkle inclusion and range proof in the NMT specification #128

Closed
staheri14 opened this issue Mar 10, 2023 · 0 comments · Fixed by #162
Closed

Explain normal Merkle inclusion and range proof in the NMT specification #128

staheri14 opened this issue Mar 10, 2023 · 0 comments · Fixed by #162
Assignees
@staheri14
Labels
documentation Improvements or additions to documentation

Comments

@staheri14
Copy link
Contributor

Problem

The NMT wrapper offers standard Merkle tree inclusion and range proof functionalities that are inherited from the encapsulated NMT. However, the current wrapper specification refers to these features in the NMT specification, which does not explicitly explain them as standalone functionalities, but rather as part of namespace proofs.

Acceptance Criteria

To address this issue, the NMT specification should include two new sections to cover normal MT inclusion and range proof, and update the wrapper to reference to these sections accordingly.
@staheri14 staheri14 changed the title # Explain normal Merkle inclusion and range proof in the NMT specification Explain normal Merkle inclusion and range proof in the NMT specification Mar 10, 2023
@staheri14 staheri14 self-assigned this Mar 10, 2023
@staheri14 staheri14 added the documentation Improvements or additions to documentation label Mar 10, 2023
This was referenced Mar 29, 2023
Closed
Merged
Closed
staheri14 added a commit that referenced this issue Apr 4, 2023
@staheri14
chore: incorporates index-based Merkle range proof in the NMT specifi…
1884bfb 
…cation (#162)

## Overview
Closes #128 

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staheri14 staheri14

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: incorporates index-based Merkle range proof in the NMT specification celestiaorg/nmt
1 participant
@staheri14