Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: incorporates index-based Merkle range proof in the NMT specification #162

Merged
merged 7 commits into from
Apr 4, 2023

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Mar 29, 2023

Overview

Closes #128

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #162 (277f3ee) into master (708cacd) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 277f3ee differs from pull request most recent head 503439a. Consider uploading reports for the commit 503439a to get more accurate results

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   96.19%   96.20%   +0.01%     
==========================================
  Files           5        6       +1     
  Lines         525      527       +2     
==========================================
+ Hits          505      507       +2     
  Misses         12       12              
  Partials        8        8              
Impacted Files Coverage Δ
nmt.go 99.02% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@staheri14 staheri14 marked this pull request as ready for review March 29, 2023 20:07
@staheri14 staheri14 self-assigned this Mar 29, 2023
@staheri14 staheri14 added the documentation Improvements or additions to documentation label Mar 29, 2023
evan-forbes
evan-forbes previously approved these changes Mar 30, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

rootulp
rootulp previously approved these changes Mar 30, 2023
@rootulp rootulp dismissed stale reviews from evan-forbes and themself via 218d517 April 1, 2023 07:52
@evan-forbes evan-forbes self-requested a review April 3, 2023 15:11
@staheri14 staheri14 requested a review from rootulp April 3, 2023 19:35
@staheri14
Copy link
Contributor Author

In case there are no further comments or feedback provided by tomorrow, I plan to proceed with merging it.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@staheri14 staheri14 merged commit 1884bfb into master Apr 4, 2023
@staheri14 staheri14 deleted the add-nmt-merkle-inclusion-prove-verify branch April 4, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain normal Merkle inclusion and range proof in the NMT specification
4 participants