Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildRangeProof can panic upon invalid input range #142

Closed
staheri14 opened this issue Mar 17, 2023 · 0 comments · Fixed by #182
Closed

buildRangeProof can panic upon invalid input range #142

staheri14 opened this issue Mar 17, 2023 · 0 comments · Fixed by #182
Assignees
@staheri14

Comments

@staheri14
Copy link
Contributor

Problem

The buildRangeProof can panic if the start and end arguments are invalid.

Acceptance Criteria

Add an initial check for the input range, and make an early return if invalid.
@staheri14 staheri14 changed the title buildRangeProof Ca panic upon invalid input range buildRangeProof can panic upon invalid input range Mar 17, 2023
@staheri14 staheri14 self-assigned this Mar 17, 2023
@staheri14 staheri14 mentioned this issue Apr 4, 2023
Closed
@staheri14 staheri14 mentioned this issue Apr 25, 2023
Merged
5 tasks
staheri14 added a commit that referenced this issue Apr 27, 2023
@staheri14
feat: returns error on invalid proof range in buildRangeProof (#182)
f05092f 
## Overview

Closes #142 

## Checklist
- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staheri14 staheri14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: returns error on invalid proof range in buildRangeProof celestiaorg/nmt
1 participant
@staheri14