feat: returns error on invalid proof range in buildRangeProof #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staheri14
requested review from
rootulp,
evan-forbes,
liamsi and
cmwaters
and removed request for
rootulp
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 94.09% 94.14% +0.05%
==========================================
Files 5 5
Lines 542 547 +5
==========================================
+ Hits 510 515 +5
Misses 18 18
Partials 14 14
|
cmwaters
previously approved these changes
Apr 26, 2023
evan-forbes
previously approved these changes
Apr 26, 2023
Yes, you are right, I added a comment to the function to make it more clear, please see fcd3cd0 |
cmwaters
previously approved these changes
Apr 26, 2023
rootulp
previously approved these changes
Apr 26, 2023
rootulp
approved these changes
Apr 26, 2023
evan-forbes
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #142
Checklist