This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
feat: implement the broadcaster #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
force-pushed
the
add_broacaster
branch
from
7d4491c to
3fdb814
Compare
# Conflicts: # orchestrator/orchestrator.go
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
===========================================
- Coverage 61.44% 42.62% -18.82%
===========================================
Files 11 14 +3
Lines 625 929 +304
===========================================
+ Hits 384 396 +12
- Misses 194 486 +292
Partials 47 47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Apologies for the delayed review on this, will be done today |
evan-forbes
reviewed
Feb 14, 2023
orchestrator/broadcaster.go
Outdated
| } | ||
|
|
||
| // Note: broadcaster implementation will be done after defining the P2P interfaces. | ||
| func (b Broadcaster) BroadcastDataCommitmentConfirm(ctx context.Context, nonce uint64, confirm types.DataCommitmentConfirm) error { |
There was a problem hiding this comment.
minor optional nit on naming, perhaps "provide", or "put" would be better here
orchestrator/broadcaster_test.go
Outdated
|
|
||
| // create a test DataCommitmentConfirm | ||
| expectedConfirm := types.DataCommitmentConfirm{ | ||
| EthAddress: "celes1qktu8009djs6uym9uwj84ead24exkezsaqrmn5", |
There was a problem hiding this comment.
6dea8bc
I lost it when I was rebasing, good catch 👍 👍
# Conflicts: # orchestrator/orchestrator.go
This was referenced Feb 14, 2023
rahulghangas
approved these changes
Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #114
Checklist