test: add orchestrator tests #134
Conversation
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 43.27% 48.21% +4.93%
==========================================
Files 15 15
Lines 952 952
==========================================
+ Hits 412 459 +47
+ Misses 491 438 -53
- Partials 49 55 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| func NewOrchestrator( | ||
| node *TestNode, | ||
| ) *orchestrator.Orchestrator { |
There was a problem hiding this comment.
[non blocking nit]
why format this like this?
There was a problem hiding this comment.
no reason :D just happened to be like that. should I change?
There was a problem hiding this comment.
@evan-forbes Can I merge or I should make the change?
There was a problem hiding this comment.
up to you! if we don't have linters for it, then I don't think its worth blocking on.
| if err != nil { | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
[optional]
why not pass a testing.T as an arg to handle errors? are we using this function outside of tests?
Overview
Depends on #133 and #115
Closes #51
Checklist