Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contracts migrations should work with v1 #5727

Closed
nambrot opened this issue Nov 5, 2020 · 0 comments · Fixed by #5795
Closed

contracts migrations should work with v1 #5727

nambrot opened this issue Nov 5, 2020 · 0 comments · Fixed by #5795
Assignees
@nambrot
Labels
Component: Contracts
Milestone
Milestone 7

Comments

@nambrot
Copy link
Contributor

nambrot commented Nov 5, 2020

No description provided.

@nambrot nambrot self-assigned this Nov 5, 2020
@nambrot nambrot added this to the Milestone 7 milestone Nov 5, 2020
@nambrot nambrot mentioned this issue Nov 10, 2020
Merged
@mergify mergify bot closed this as completed in #5795 Nov 12, 2020
mergify bot pushed a commit that referenced this issue Nov 12, 2020
@nambrot
Adjust migrations for Testnet contract deploys (#5795)
e8cbbd8 
### Description

Over time, our migrationsConfig have become out of sync and thus the current state does not yield a satisfactory experience for deploying contracts on a real testnet (i.e. not ganache). As I've been working more on env-test, I also adjusted the default migration overrides to make some special keys more accessible on these testnets.

As a result, testnet contract deploys should work out of the box, and an upcoming PR for env-tests will make running these tests work out of the box as well.

### Tested

- On my own testnets

Fixes #5727
@snyk-bot snyk-bot mentioned this issue Nov 24, 2022
Open
@lili2311 lili2311 mentioned this issue Aug 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nambrot nambrot

Labels
Component: Contracts
Projects
None yet
Milestone
Milestone 7
Development

Successfully merging a pull request may close this issue.

Adjust migrations for Testnet contract deploys celo-org/celo-monorepo
1 participant
@nambrot