Adjust migrations for Testnet contract deploys #5795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nambrot
requested review from
asaj,
cmcewen,
nategraf and
timmoreton
as code owners
nambrot
commented
Nov 10, 2020
| @@ -506,10 +430,139 @@ const NetworkConfigs = { | |||
| votesRatioOfLastVsFirstGroup: 1.0, | |||
| }, | |||
| }, | |||
| rc1: { | |||
There was a problem hiding this comment.
This is copied for the most part from the old Default config
nambrot
added
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Over time, our migrationsConfig have become out of sync and thus the current state does not yield a satisfactory experience for deploying contracts on a real testnet (i.e. not ganache). As I've been working more on env-test, I also adjusted the default migration overrides to make some special keys more accessible on these testnets.
As a result, testnet contract deploys should work out of the box, and an upcoming PR for env-tests will make running these tests work out of the box as well.
Tested
Fixes #5727