Disable import wallet button when the backup phrase is not valid #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrossy
suggested changes
Sep 16, 2019
| @@ -177,7 +177,7 @@ export class ImportWallet extends React.Component<Props, State> { | |||
| </View> | |||
| )} | |||
| <GethAwareButton | |||
| disabled={isSubmitting || !this.state.backupPhrase} | |||
| disabled={isSubmitting || this.state.backupPhrase.trim().split(/\s+/g).length < 12} | |||
There was a problem hiding this comment.
Consider creating an isBackupPhraseValid method and doing this check there
There was a problem hiding this comment.
Also, did you mean 24 instead of 12?
There was a problem hiding this comment.
The issue considers both: 12 and 24. Is it ok?
There was a problem hiding this comment.
Consider creating an
isBackupPhraseValidmethod and doing this check there
Sure!
Codecov Report
@@ Coverage Diff @@
## master #1012 +/- ##
==========================================
+ Coverage 66.92% 66.93% +<.01%
==========================================
Files 252 252
Lines 7311 7312 +1
Branches 418 418
==========================================
+ Hits 4893 4894 +1
Misses 2331 2331
Partials 87 87
Continue to review full report at Codecov.
|
jmrossy
reviewed
Sep 16, 2019
| @@ -126,6 +126,10 @@ export class ImportWallet extends React.Component<Props, State> { | |||
| } | |||
| } | |||
|
|
|||
| isBackupPhraseValid() { | |||
There was a problem hiding this comment.
Guess this should be isBackupPhraseInvalid
There was a problem hiding this comment.
Fixed! And added more details on tested section. Is it ok?
There was a problem hiding this comment.
Is it fixed? Still shows as Valid for me
Pedro-vk
force-pushed
the
feature/#802-enable-import-wallet-button-on-valid-phrase
branch
from
6256b26
to
f0b1fc7
Compare
jmrossy
approved these changes
Sep 17, 2019
…button-on-valid-phrase
aaronmgdr
added a commit
that referenced
this pull request
Sep 17, 2019
* master: (132 commits) [Wallet] Differentiate dollars and gold transactions (#1021) [wip] LinkedList cycle fix (#941) Fix slither issues (#572) [Wallet] Disable import wallet button when the backup phrase is not valid (#1012) Fix fixed fraction division underflow (#952) [CircleCI]Run protocol coverage once a day (#1018) Expose and test validator set precompiles (#874) [celotool] Fund Faucet accounts on network init (#990) Add Nexmo as a text provider for MX and US numbers (#1002) [CircleCI]Run protocol test with and without coverage (#991) Increase memory requests for Alfajores nodes (#966) [wallet]Select blockchain url based on testnet (#936) Pilot app config and ability to not show testnet banner (#1009) Add Linux onboarding steps and a TOC to SETUP.md (#1004) Add README-dev.md (#989) [Wallet] Exchange flow formatting fixes (#961) [celotool] Cleanup genesis block generation (#988) [celotool] Some ❤️. Clean up (#948) CeloCLI sorted list of Validator Groups should not include groups with zero votes (#907) [contractkit] Fix tests (#963) ...
aaronmgdr
added a commit
that referenced
this pull request
Sep 18, 2019
* master: (72 commits) Remove unused Reserve.burnToken function (#984) Persistent disks for transaction nodes (#1016) [Wallet] Differentiate dollars and gold transactions (#1021) [wip] LinkedList cycle fix (#941) Fix slither issues (#572) [Wallet] Disable import wallet button when the backup phrase is not valid (#1012) Fix fixed fraction division underflow (#952) [CircleCI]Run protocol coverage once a day (#1018) Expose and test validator set precompiles (#874) [celotool] Fund Faucet accounts on network init (#990) Add Nexmo as a text provider for MX and US numbers (#1002) [CircleCI]Run protocol test with and without coverage (#991) Increase memory requests for Alfajores nodes (#966) [wallet]Select blockchain url based on testnet (#936) Pilot app config and ability to not show testnet banner (#1009) Add Linux onboarding steps and a TOC to SETUP.md (#1004) Add README-dev.md (#989) [Wallet] Exchange flow formatting fixes (#961) [celotool] Cleanup genesis block generation (#988) [celotool] Some ❤️. Clean up (#948) ... # Conflicts: # packages/web/src/header/Header.3.tsx
aaronmgdr
added a commit
that referenced
this pull request
Sep 18, 2019
* master: (38 commits) Remove unused Reserve.burnToken function (#984) Persistent disks for transaction nodes (#1016) [Wallet] Differentiate dollars and gold transactions (#1021) [wip] LinkedList cycle fix (#941) Fix slither issues (#572) [Wallet] Disable import wallet button when the backup phrase is not valid (#1012) Fix fixed fraction division underflow (#952) [CircleCI]Run protocol coverage once a day (#1018) Expose and test validator set precompiles (#874) [celotool] Fund Faucet accounts on network init (#990) Add Nexmo as a text provider for MX and US numbers (#1002) [CircleCI]Run protocol test with and without coverage (#991) Increase memory requests for Alfajores nodes (#966) [wallet]Select blockchain url based on testnet (#936) Pilot app config and ability to not show testnet banner (#1009) Add Linux onboarding steps and a TOC to SETUP.md (#1004) Add README-dev.md (#989) [Wallet] Exchange flow formatting fixes (#961) [celotool] Cleanup genesis block generation (#988) [celotool] Some ❤️. Clean up (#948) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable import wallet button when the backup phrase is not valid
Tested
Changes were tested on Android emulator, going to import wallet view and filling the textarea with different words, checking that adding the 12th word (or first letter of the word) enables the button
Related issues
Backwards compatibility
It doesn't affect compatibility