[wip] LinkedList cycle fix #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
=======================================
Coverage 66.93% 66.93%
=======================================
Files 252 252
Lines 7312 7312
Branches 482 418 -64
=======================================
Hits 4894 4894
- Misses 2329 2331 +2
+ Partials 89 87 -2
Continue to review full report at Codecov.
|
m-chrzan
reviewed
Sep 12, 2019
| @@ -69,7 +69,7 @@ const DefaultConfig = { | |||
| } | |||
|
|
|||
| const linkedLibraries = { | |||
| LinkedList: ['AddressLinkedList', 'SortedLinkedList'], | |||
| LinkedList: ['AddressLinkedList', 'SortedLinkedList', 'LinkedListTest'], | |||
There was a problem hiding this comment.
I think it'd be best if we didn't need to link test contracts in the production migrations. Can this linking be done in a before in the Truffle tests?
There was a problem hiding this comment.
I don't think it will have any impact in a production migration (because the test contracts should not be deployed then). Anyway, you can check from this branch what linking inside the testsuite would look like: https://github.com/mrsmkl/celo-monorepo/compare/linked-list...mrsmkl:linking?expand=1
So one problem is that there is no link property for contracts in Truffle typings. But I can do the same thing for other test contracts too.
m-chrzan
approved these changes
Sep 16, 2019
aaronmgdr
added a commit
that referenced
this pull request
Sep 17, 2019
* master: (132 commits) [Wallet] Differentiate dollars and gold transactions (#1021) [wip] LinkedList cycle fix (#941) Fix slither issues (#572) [Wallet] Disable import wallet button when the backup phrase is not valid (#1012) Fix fixed fraction division underflow (#952) [CircleCI]Run protocol coverage once a day (#1018) Expose and test validator set precompiles (#874) [celotool] Fund Faucet accounts on network init (#990) Add Nexmo as a text provider for MX and US numbers (#1002) [CircleCI]Run protocol test with and without coverage (#991) Increase memory requests for Alfajores nodes (#966) [wallet]Select blockchain url based on testnet (#936) Pilot app config and ability to not show testnet banner (#1009) Add Linux onboarding steps and a TOC to SETUP.md (#1004) Add README-dev.md (#989) [Wallet] Exchange flow formatting fixes (#961) [celotool] Cleanup genesis block generation (#988) [celotool] Some ❤️. Clean up (#948) CeloCLI sorted list of Validator Groups should not include groups with zero votes (#907) [contractkit] Fix tests (#963) ...
aaronmgdr
added a commit
that referenced
this pull request
Sep 18, 2019
* master: (72 commits) Remove unused Reserve.burnToken function (#984) Persistent disks for transaction nodes (#1016) [Wallet] Differentiate dollars and gold transactions (#1021) [wip] LinkedList cycle fix (#941) Fix slither issues (#572) [Wallet] Disable import wallet button when the backup phrase is not valid (#1012) Fix fixed fraction division underflow (#952) [CircleCI]Run protocol coverage once a day (#1018) Expose and test validator set precompiles (#874) [celotool] Fund Faucet accounts on network init (#990) Add Nexmo as a text provider for MX and US numbers (#1002) [CircleCI]Run protocol test with and without coverage (#991) Increase memory requests for Alfajores nodes (#966) [wallet]Select blockchain url based on testnet (#936) Pilot app config and ability to not show testnet banner (#1009) Add Linux onboarding steps and a TOC to SETUP.md (#1004) Add README-dev.md (#989) [Wallet] Exchange flow formatting fixes (#961) [celotool] Cleanup genesis block generation (#988) [celotool] Some ❤️. Clean up (#948) ... # Conflicts: # packages/web/src/header/Header.3.tsx
aaronmgdr
added a commit
that referenced
this pull request
Sep 18, 2019
* master: (38 commits) Remove unused Reserve.burnToken function (#984) Persistent disks for transaction nodes (#1016) [Wallet] Differentiate dollars and gold transactions (#1021) [wip] LinkedList cycle fix (#941) Fix slither issues (#572) [Wallet] Disable import wallet button when the backup phrase is not valid (#1012) Fix fixed fraction division underflow (#952) [CircleCI]Run protocol coverage once a day (#1018) Expose and test validator set precompiles (#874) [celotool] Fund Faucet accounts on network init (#990) Add Nexmo as a text provider for MX and US numbers (#1002) [CircleCI]Run protocol test with and without coverage (#991) Increase memory requests for Alfajores nodes (#966) [wallet]Select blockchain url based on testnet (#936) Pilot app config and ability to not show testnet banner (#1009) Add Linux onboarding steps and a TOC to SETUP.md (#1004) Add README-dev.md (#989) [Wallet] Exchange flow formatting fixes (#961) [celotool] Cleanup genesis block generation (#988) [celotool] Some ❤️. Clean up (#948) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just add the check to make sure that when inserting, the added key cannot be the same as the previous or next key.
Tested
Added some test files, didn't see any existing test for simple linked lists, and there were already checks for this in the other cases. I still want to add a test that would have actually made a cycle with the previous code.
Other changes
None
Related issues
Backwards compatibility
No effect.