Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added txpool family to geth apis. Sorted geth cmd options #1462

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

jcortejoso
Copy link
Member

Description

Added the api family txpool (doc) needed by Blockscout.

Tested

The method works locally. Not tested yet deploying using helm

Other changes

Sorted the cmd options of the geth command to ease the changes between sections

Related issues

  • Fixes #[issue number here]

Backwards compatibility

The change should not affect compatibility in any way.

@jcortejoso
Copy link
Member Author

Currently Blockscout Indexer shows this error due to the lack of this API:

iex(1)> 2019-10-24T13:37:19.648 application=indexer fetcher=pending_transaction [error] pending transaction fetcher task exited due to {{:case_clause, {:error, %{code: -32601, message: "The method txpool_content does not exist/is not available"}}}, [{Indexer.Fetcher.PendingTransaction, :task, 1, [file: 'lib/indexer/fetcher/pending_transaction.ex', line: 120]}, {Task.Supervised, :invoke_mfa, 2, [file: 'lib/task/supervised.ex', line: 90]}, {Task.Supervised, :reply, 5, [file: 'lib/task/supervised.ex', line: 35]}, {:proc_lib, :init_p_do_apply, 3, [file: 'proc_lib.erl', line: 249]}]}.  Rescheduling.
iex(1)> 2019-10-24T13:37:20.651 fetcher=pending_transaction [error] Task #PID<0.9756.2> started from Indexer.Fetcher.PendingTransaction terminating
** (CaseClauseError) no case clause matching: {:error, %{code: -32601, message: "The method txpool_content does not exist/is not available"}}
    (indexer) lib/indexer/fetcher/pending_transaction.ex:120: Indexer.Fetcher.PendingTransaction.task/1
    (elixir) lib/task/supervised.ex:90: Task.Supervised.invoke_mfa/2
    (elixir) lib/task/supervised.ex:35: Task.Supervised.reply/5
    (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3
Function: #Function<2.56896065/0 in Indexer.Fetcher.PendingTransaction.handle_info/2>
    Args: []

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #1462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1462   +/-   ##
=======================================
  Coverage   73.74%   73.74%           
=======================================
  Files         277      277           
  Lines        7420     7420           
  Branches      660      660           
=======================================
  Hits         5472     5472           
  Misses       1836     1836           
  Partials      112      112
Flag Coverage Δ
#mobile 73.74% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fc2ddf...f5d1ece. Read the comment docs.

@asaj asaj added the automerge Have PR merge automatically when checks pass label Oct 30, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit 433838a into celo-org:master Oct 30, 2019
aaronmgdr added a commit that referenced this pull request Nov 2, 2019
* master: (62 commits)
  Fix e2e on CI (#1537)
  Allow a specified address to disable/enable the Exchange  (#1467)
  Avoid re-encrypting key files with yarn keys:encrypt command (#1560)
  Support protocol hotfixing (#613)
  Point e2e tests back (#1562)
  Refactor to Accounts.sol (#1392)
  Add selectIssuers Transaction (#1327)
  [Wallet] Get React Native Hot Reloading Working (#1551)
  Unify to prefix messages for signing (#1473)
  [Wallet] Improve error handling around account creation and keystore ops (#1497)
  Add CI test for checking licenses and misc package.json cleanup (#1550)
  [Wallet] Implement SMS invite on iOS (#1541)
  CI: brings back to master (#1554)
  Validators: uses Ethereum address for proof of possession (#1494)
  Validate Attestation Requests (#1468)
  Rename hosted node references to forno (#1511)
  Bump rubyzip from 1.2.3 to 1.3.0 in /packages/mobile (#1508)
  Added txpool family to geth apis. Sorted geth cmd options (#1462)
  [Wallet] Fix yarn dev command for running android (#1534)
  [Wallet] iOS info plist changes and version bump (#1539)
  ...

# Conflicts:
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants