Add CI test for checking licenses and misc package.json cleanup #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrossy
requested review from
aaronmgdr,
asaj,
ashishb,
cmcewen,
m-chrzan and
yerdua
as code owners
jmrossy
changed the title
jeanregisser
approved these changes
Oct 31, 2019
Comment on lines
-139
to
-141
| // Note: Unfortunately, RN-Geth doesn't currently support connecting to the | ||
| // already running geth instance, which we would need to subscribe to head updates. | ||
| // In the meantime, we need to force an app reset. See #3227 |
There was a problem hiding this comment.
Is this comment not relevant anymore?
There was a problem hiding this comment.
It won't be once my hot reloading Pr goes in. I accidentally included it here but it's nbd
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
==========================================
+ Coverage 73.72% 73.75% +0.02%
==========================================
Files 277 277
Lines 7422 7418 -4
Branches 661 954 +293
==========================================
- Hits 5472 5471 -1
+ Misses 1838 1835 -3
Partials 112 112
Continue to review full report at Codecov.
|
aaronmgdr
added a commit
that referenced
this pull request
Nov 2, 2019
* master: (62 commits) Fix e2e on CI (#1537) Allow a specified address to disable/enable the Exchange (#1467) Avoid re-encrypting key files with yarn keys:encrypt command (#1560) Support protocol hotfixing (#613) Point e2e tests back (#1562) Refactor to Accounts.sol (#1392) Add selectIssuers Transaction (#1327) [Wallet] Get React Native Hot Reloading Working (#1551) Unify to prefix messages for signing (#1473) [Wallet] Improve error handling around account creation and keystore ops (#1497) Add CI test for checking licenses and misc package.json cleanup (#1550) [Wallet] Implement SMS invite on iOS (#1541) CI: brings back to master (#1554) Validators: uses Ethereum address for proof of possession (#1494) Validate Attestation Requests (#1468) Rename hosted node references to forno (#1511) Bump rubyzip from 1.2.3 to 1.3.0 in /packages/mobile (#1508) Added txpool family to geth apis. Sorted geth cmd options (#1462) [Wallet] Fix yarn dev command for running android (#1534) [Wallet] iOS info plist changes and version bump (#1539) ... # Conflicts: # yarn.lock
This was referenced Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorry, this one's a bit of a catchall PR
Tested
Tested locally, and CI tests will test the new check licenses job :)