[Wallet] Hotfix local currency #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent incorrect usage of hooks
- fix crash when changing local currency from the settings due to hooks incorrectly used - fix dollar exchange rate value shown converted to local currency in the exchange confirmation card - fix received gold amounts shown in the local currency
jeanregisser
force-pushed
the
jeanregisser/hotfix-local-currency
branch
from
02863db
to
00ea1cc
Compare
jeanregisser
commented
Oct 25, 2019
Comment on lines
+17
to
18
| // tslint:disable-next-line: react-hooks-nesting | ||
| const selectedCurrencyCode = useLocalCurrencyCode() || DEFAULT_CURRENCY_CODE |
There was a problem hiding this comment.
false positive because we're using || DEFAULT_CURRENCY_CODE
jeanregisser
commented
Oct 25, 2019
| @@ -67,11 +67,12 @@ const renderTopSection = (props: Props) => { | |||
| const renderAmountSection = (props: Props) => { | |||
| const { currency, type, value } = props | |||
|
|
|||
| // tslint:disable react-hooks-nesting | |||
There was a problem hiding this comment.
false positive because this function is called inside another render function and that lint rules can't figure it out.
jmrossy
approved these changes
Oct 25, 2019
…l screen card details
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
+ Coverage 65.49% 65.49% +<.01%
==========================================
Files 271 271
Lines 8144 8165 +21
Branches 491 501 +10
==========================================
+ Hits 5334 5348 +14
- Misses 2697 2699 +2
- Partials 113 118 +5
Continue to review full report at Codecov.
|
aaronmgdr
added a commit
that referenced
this pull request
Oct 29, 2019
…repo into aaronmgdr/invite-page * 'aaronmgdr/invite-page' of github.com:celo-org/celo-monorepo: (63 commits) Fix compile error during local clean build (#1506) Update to RN 61 and AndroidX (#1343) Set usage of shuffled round robin in the genesis block (#1464) Add spanish backup key for backup key flow (#1500) Fix sync tests by pulling genesis block to determine epoch length (#1504) [Wallet] fix missing full name error alert (#1496) [Wallet + Verification Pool] Add details about generating an app-signature (#1482) Deploy celo's image of ethstats (#1421) Storing previous randomness values (#1197) [Wallet] Fix wei invite bug (#1489) Point all packages to latest ganache-cli master (#1488) Point end-to-end tests back to master (#1469) [Wallet] Migrate app view functions to contractkit (#1381) [Wallet] Add script to translate locale strings (#1485) [Wallet] Update wallet celo client version and add missing translations for backup flow (#1483) [Wallet] Hotfix local currency (#1481) [Wallet] Remove QR debouncing to improve responsiveness (#1480) [Wallet] Upgrade app version to v1.5.1 (#1463) Update governance end-to-end tests to work with changed precompile (#1476) Fixes key_placer.sh when encrypting files (#1465) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed some regressions introduced by #1325
This will probably need further refactoring, the logic is easy to break given the different use cases.
Tested
Other changes
N/A
Related issues
Backwards compatibility
Yes