Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spanish backup key for backup key flow #1500

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

nityas
Copy link
Contributor

@nityas nityas commented Oct 28, 2019

Description

Adds translated strings for backup key flow

Tested

in progress, running the app

Other changes

n/a

Related issues

Backwards compatibility

copy change

Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@jmrossy jmrossy assigned nityas and unassigned jmrossy Oct 28, 2019
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #1500 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   65.39%   65.39%           
=======================================
  Files         271      271           
  Lines        8187     8187           
  Branches      501      570   +69     
=======================================
  Hits         5354     5354           
+ Misses       2712     2711    -1     
- Partials      121      122    +1
Flag Coverage Δ
#mobile 65.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/identity/reducer.ts 41.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3e000...3cdaa7b. Read the comment docs.

@nityas nityas added the automerge Have PR merge automatically when checks pass label Oct 28, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit 5ecafd5 into master Oct 28, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the nitya/backup-translations branch October 28, 2019 23:43
aaronmgdr added a commit that referenced this pull request Oct 29, 2019
…repo into aaronmgdr/invite-page

* 'aaronmgdr/invite-page' of github.com:celo-org/celo-monorepo: (63 commits)
  Fix compile error during local clean build (#1506)
  Update to RN 61 and AndroidX (#1343)
  Set usage of shuffled round robin in the genesis block (#1464)
  Add spanish backup key for backup key flow (#1500)
  Fix sync tests by pulling genesis block to determine epoch length (#1504)
  [Wallet] fix missing full name error alert (#1496)
  [Wallet + Verification Pool] Add details about generating an app-signature (#1482)
  Deploy celo's image of ethstats (#1421)
  Storing previous randomness values (#1197)
  [Wallet] Fix wei invite bug (#1489)
  Point all packages to latest ganache-cli master (#1488)
  Point end-to-end tests back to master (#1469)
  [Wallet] Migrate app view functions to contractkit (#1381)
  [Wallet] Add script to translate locale strings (#1485)
  [Wallet] Update wallet celo client version and add missing translations for backup flow (#1483)
  [Wallet] Hotfix local currency (#1481)
  [Wallet] Remove QR debouncing to improve responsiveness (#1480)
  [Wallet] Upgrade app version to v1.5.1 (#1463)
  Update governance end-to-end tests to work with changed precompile (#1476)
  Fixes key_placer.sh when encrypting files (#1465)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet needs spanish translations for the new backup flow
4 participants