Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Fix notifications #1637

Merged
merged 3 commits into from
Nov 9, 2019
Merged

Conversation

i1skn
Copy link
Contributor

@i1skn i1skn commented Nov 8, 2019

Description

Notifications were broken because we use mix of lowercased addresses with original ones (with some capital letters). This PR enforcing lowercase in the redux state.

Tested

Ran on Android device and iOS simulator.

Other changes

Also, fix this issue at update payment request (see here why https://github.com/invertase/react-native-firebase/blob/ea901386db3d2414c124b208b5f8538175528c9d/src/modules/database/Reference.js#L193)

Related issues

Backwards compatibility

Yes

@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #1637 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
- Coverage   74.24%   74.23%   -0.01%     
==========================================
  Files         287      287              
  Lines        7703     7704       +1     
  Branches      666      667       +1     
==========================================
  Hits         5719     5719              
  Misses       1871     1871              
- Partials      113      114       +1
Flag Coverage Δ
#mobile 74.23% <33.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
packages/mobile/src/web3/reducer.ts 50% <ø> (ø) ⬆️
packages/mobile/src/firebase/saga.ts 25% <0%> (ø) ⬆️
packages/mobile/src/web3/selectors.ts 80% <50%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2788391...9449c0e. Read the comment docs.

@jmrossy jmrossy changed the title Fix notifications [Wallet] Fix notifications Nov 8, 2019
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants