Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for the pilot app #1646

Merged
merged 2 commits into from
Nov 10, 2019
Merged

Conversation

cmcewen
Copy link
Contributor

@cmcewen cmcewen commented Nov 9, 2019

Description

Few fixes for the pilot app to work

  • network is still deployed with infura url
  • symlink the yarn.lock in blockchain-api
  • set default env for local dev to pilot in mobile
  • fix firebase url in google-services.json file
  • set address to lowercase in firebase after [Wallet] Fix notifications #1637 otherwise the app will throw an error

Tested

Did a build of the app and went through verification

fixes #1647

Backwards compatibility

Firebase change was backwards incompatible

@codecov
Copy link

codecov bot commented Nov 9, 2019

Codecov Report

Merging #1646 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1646    +/-   ##
========================================
  Coverage   74.23%   74.23%            
========================================
  Files         287      287            
  Lines        7704     7704            
  Branches      960      667   -293     
========================================
  Hits         5719     5719            
  Misses       1871     1871            
  Partials      114      114
Flag Coverage Δ
#mobile 74.23% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/web3/actions.ts 77.41% <ø> (ø) ⬆️
packages/mobile/src/config.ts 88.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1923f86...ee4adc4. Read the comment docs.

@cmcewen cmcewen added the automerge Have PR merge automatically when checks pass label Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: User address in the db doesn't match persisted address
6 participants