[wallet] Doesn't calculate fee on empty balance #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrossy
reviewed
Nov 11, 2019
martinvol
changed the title
martinvol
force-pushed
the
martinvol/fee_empty_balance
branch
from
ba1b9b8
to
17d74ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #1652 +/- ##
==========================================
+ Coverage 73.81% 73.81% +<.01%
==========================================
Files 279 279
Lines 7600 7608 +8
Branches 950 950
==========================================
+ Hits 5610 5616 +6
- Misses 1875 1877 +2
Partials 115 115
Continue to review full report at Codecov.
|
martinvol
force-pushed
the
martinvol/fee_empty_balance
branch
from
17d74ca
to
d96849e
Compare
jmrossy
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents the app from updating fees if the balance is zero, due web3 known issue.
Tested
Added test case and mocked the others.
Other changes
Related issues
Backwards compatibility